Ryan Barry has posted comments on this change. Change subject: If miss custom netconsole port, using default netconsole port "6666" to set ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28347/1/src/ovirtnode/log.py File src/ovirtnode/log.py: Line 180: def netconsole_auto(): Line 181: host = "" Line 182: port = "" Line 183: if (not "OVIRT_NETCONSOLE_SERVER" in _functions.OVIRT_VARS and not Line 184: "OVIRT_NETCONSOLE_PORT" in _functions.OVIRT_VARS): Same comments as the syslog patch. We'll block DNS SRV discovery by doing this. Line 185: logger.info("Attempting to locate remote netconsole server...") Line 186: try: Line 187: host, port = _functions.find_srv("netconsole", "udp") Line 188: except: Line 186: try: Line 187: host, port = _functions.find_srv("netconsole", "udp") Line 188: except: Line 189: pass Line 190: if not host is "" and not port is "": Probably check for false here. Line 191: logger.info("Found! Using netconsole server " + host + ":" + port) Line 192: ovirt_netconsole(host, port) Line 193: return True Line 194: else: -- To view, visit http://gerrit.ovirt.org/28347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf5d62200ae3a8307c2e06946ec5b9992180b581 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: hadong <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
