Fabian Deutsch has posted comments on this change. Change subject: snmp auto：fix snmp page still shown disabled issue ......................................................................
Patch Set 10: Verified-1 Code-Review-1 (2 comments) Some inline comments http://gerrit.ovirt.org/#/c/22727/10/plugins/snmp_autoinstall.py File plugins/snmp_autoinstall.py: Line 24: args = _functions.get_cmdline_args() Line 25: Line 26: snmp_pw = args.get("snmp_password") Line 27: Line 28: changes = dict((keys_to_model[key], args[key]) for key in keys if key in args) keys_to_model does not exist. I do not see the need for this variable (changes) at all. Line 29: Line 30: if __name__ == "__main__": Line 31: snmp = snmp_model.SNMP() Line 32: if len(snmp_pw) > 0: http://gerrit.ovirt.org/#/c/22727/10/src/ovirtnode/ovirtfunctions.py File src/ovirtnode/ovirtfunctions.py: Line 1192: # run post-install hooks Line 1193: # e.g. to avoid reboot loops using Cobbler PXE only once Line 1194: # Cobbler XMLRPC post-install trigger (XXX is there cobbler SRV record?): Line 1195: # wget "http://192.168.50.2/cblr/svc/op/trig/mode/post/system/$(hostname)" Line 1196: # -O /dev/null Why ain't the hooks run here at all? We need them to run the hooks i.e. which are explained above. Line 1197: for f in ["/etc/ssh/ssh_host%s_key" % t for t in ["", "_dsa", "_rsa"]]: Line 1198: ovirt_store_config(f) Line 1199: ovirt_store_config("%s.pub" % f) Line 1200: for f in OVIRT_CONFIG_FILES: -- To view, visit http://gerrit.ovirt.org/22727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113f9835d9ac76deaab50bd9e8dfcb034328e441 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: hadong <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
