Fabian Deutsch has posted comments on this change. Change subject: Fix value error during configuring installation.device.custom into "/dev/sda,/dev/sdb". ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29622/1/src/ovirt/node/installer/core/installation_device_page.py File src/ovirt/node/installer/core/installation_device_page.py: Line 170: elif changes.contains_any(["installation.device.custom", Line 171: "dialog.device.custom.save"]): Line 172: self._dialog.close() Line 173: m = self._model Line 174: cdevs = m["installation.device.custom"].split(",") this should be: cdevs = m.get("installation.device.custom", "").split(",") or [] In case that installation.device.custom is not set. Line 175: m.setdefault("installation.devices", []).extend(cdevs) Line 176: self.application.ui.navigate.to_next_plugin() Line 177: Line 178: if changes.contains_any(["button.back"]): -- To view, visit http://gerrit.ovirt.org/29622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a98405dfe27445d17b002e744a8ca2e50660174 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: hadong <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
