Fabian Deutsch has posted comments on this change. Change subject: Unbreak netconsole ......................................................................
Patch Set 1: (1 comment) An inline question http://gerrit.ovirt.org/#/c/30118/1/src/ovirt/node/config/defaults.py File src/ovirt/node/config/defaults.py: Line 1340: server, port = (cfg["server"], cfg["port"]) Line 1341: Line 1342: class CreateNetconsoleConfig(utils.Transaction.Element): Line 1343: if server: Line 1344: port = port if 'port' in vars() else "6666" Why is this necessary? (The vars() call) Shouldn't vars be initialized above? Line 1345: title = "Setting netconsole server and port" Line 1346: else: Line 1347: title = "Disabling netconsole" Line 1348: -- To view, visit http://gerrit.ovirt.org/30118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546bd4da86f6aa5a3ea8f6c3877582519d6ceb88 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
