Ryan Barry has uploaded a new change for review. Change subject: Swallow output from LVM creation again ......................................................................
Swallow output from LVM creation again Back to system instead of system_closefds so we don't clutter the screen Change-Id: Iac851473a5082c9aecd2c8c8b35875de2f897449 Signed-off-by: Ryan Barry <[email protected]> --- M src/ovirtnode/storage.py 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/76/32876/1 diff --git a/src/ovirtnode/storage.py b/src/ovirtnode/storage.py index 86052ec..6bda242 100644 --- a/src/ovirtnode/storage.py +++ b/src/ovirtnode/storage.py @@ -511,7 +511,7 @@ drv_count = drv_count + 1 if self.SWAP_SIZE > 0: logger.info("Creating swap partition") - _functions.system_closefds("yes | lvcreate --name Swap --size " + \ + _functions.system("yes | lvcreate --name Swap --size " + \ str(self.SWAP_SIZE) + "M /dev/HostVG") _functions.system("mkswap -L \"SWAP\" /dev/HostVG/Swap") _functions.system_closefds("echo \"/dev/HostVG/Swap swap swap " + @@ -523,14 +523,14 @@ "\" >> /etc/ovirt-crypttab") if self.CONFIG_SIZE > 0: logger.info("Creating config partition") - _functions.system_closefds("yes | lvcreate --name Config --size " + + _functions.system("yes | lvcreate --name Config --size " + str(self.CONFIG_SIZE) + "M /dev/HostVG") _functions.system("mke2fs -j -t ext4 /dev/HostVG/Config " + \ "-L \"CONFIG\"") _functions.system("tune2fs -c 0 -i 0 /dev/HostVG/Config") if self.LOGGING_SIZE > 0: logger.info("Creating log partition") - _functions.system_closefds("yes | lvcreate --name Logging --size " + + _functions.system("yes | lvcreate --name Logging --size " + str(self.LOGGING_SIZE) + "M /dev/HostVG") _functions.system("mke2fs -j -t ext4 /dev/HostVG/Logging " + \ "-L \"LOGGING\"") @@ -541,11 +541,11 @@ use_data = 1 if self.DATA_SIZE == -1: logger.info("Creating data partition with remaining free space") - _functions.system_closefds("yes | lvcreate --name Data -l 100%FREE /dev/HostVG") + _functions.system("yes | lvcreate --name Data -l 100%FREE /dev/HostVG") use_data = 0 elif self.DATA_SIZE > 0: logger.info("Creating data partition") - _functions.system_closefds("yes | lvcreate --name Data --size " + \ + _functions.system("yes | lvcreate --name Data --size " + \ str(self.DATA_SIZE) + "M /dev/HostVG") use_data = 0 if use_data == 0: @@ -679,7 +679,7 @@ lv_cmd = ("yes | lvcreate --name Swap2 --size \"" + str(self.SWAP2_SIZE) + "M\" /dev/AppVG") logger.debug(lv_cmd) - _functions.system_closefds(lv_cmd) + _functions.system(lv_cmd) if "OVIRT_CRYPT_SWAP2" in _functions.OVIRT_VARS: _functions.system_closefds("echo \"SWAP2 /dev/AppVG/Swap2 " + "/dev/mapper/ovirt-crypt-swap2 " + @@ -693,11 +693,11 @@ use_data = "1" if self.DATA2_SIZE == -1: logger.info("Creating data2 partition with remaining free space") - _functions.system_closefds("yes | lvcreate --name Data2 -l 100%FREE /dev/AppVG") + _functions.system("yes | lvcreate --name Data2 -l 100%FREE /dev/AppVG") use_data = 0 elif self.DATA2_SIZE > 0: logger.info("Creating data2 partition") - _functions.system_closefds("yes | lvcreate --name Data2 --size " + \ + _functions.system("yes | lvcreate --name Data2 --size " + \ str(self.DATA2_SIZE) + "M /dev/AppVG") use_data = 0 -- To view, visit http://gerrit.ovirt.org/32876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac851473a5082c9aecd2c8c8b35875de2f897449 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
