Douglas Schilling Landgraf has posted comments on this change.

Change subject: Don't put output to the screen in ovirt-cleanup
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33408/1/dracut/ovirt-cleanup.sh
File dracut/ovirt-cleanup.sh:

Line 184:                     exit 1
Line 185:                 fi
Line 186:             done
Line 187:             info "Found and removing vg: $vg"
Line 188:             yes 2>/dev/null | lvm vgremove -ff "$vg" 2>/dev/null
Curious question Ryan: Could we do &> /dev/null?
Line 189:         fi
Line 190:         info "Found and removing pv: $pv"
Line 191:         yes 2>/dev/null | lvm pvremove -ff "$pv" 2>/dev/null
Line 192:     done


-- 
To view, visit http://gerrit.ovirt.org/33408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a9f96e8392b469794ae84389ef8c6cbe694ff1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to