Nir Soffer has posted comments on this change.

Change subject: Don't use lvmetad
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33540/1/recipe/rhevh7-post.ks
File recipe/rhevh7-post.ks:

Line 6: dirs    /var/db
Line 7: EOF_RWTAB_RHEVH
Line 8: 
Line 9: # disable lvmetad rhbz#1147217
Line 10: sed -ie 's/use_lvmetad = 1/use_lvmetad = 0' /etc/lvm/lvm.conf
First, this is little fragile - for example, if the conf is use_lvmetad=1.

Second will also cause unwanted change in a comment like this:

    # To enable lvmetad, set use_lvmetad to 1:
    #    use_lvmetad = 1

Last, if there is no such configuration in the conf file, this will not make 
any change, and lvm will use the default (which may be use_lvmetad = 1).

Practically this should work though.
Line 11: systemctl disable lvm2-lvmetad
Line 12: 
Line 13: # minimal lsb_release for bz#549147
Line 14: cat > /usr/bin/lsb_release <<\EOF_LSB


-- 
To view, visit http://gerrit.ovirt.org/33540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie111f462d15bde004506638e3d70943e3dd9daba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to