Fabian Deutsch has posted comments on this change. Change subject: spec: replace a patch with sed cmd ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33001/3/ovirt-node.spec.in File ovirt-node.spec.in: Line 187: %else Line 188: patch -d /usr/share/ruby/vendor_ruby/facter -p0 < \ Line 189: %endif Line 190: %{app_root}/puppet-plugin/puppet-operatingsystem.rb.patch Line 191: sed -i -e "/server/ s/^/# /;/certname/ s/^/# /;" /etc/puppet/puppet.conf This is to greedy, imagine the folölowing lines which will be affected: # and the server will do or enable_server_security = True The last line would be commented out and might lead to issues. Please adjust the match expression to only comment out the correct lines. Line 192: Line 193: %if %{is_el6} Line 194: echo 'files /var/lib/puppet' >> /etc/rwtab Line 195: %endif -- To view, visit http://gerrit.ovirt.org/33001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d7f39fcd3d67b6f429d056706739617d2a9dcb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
