Fabian Deutsch has posted comments on this change. Change subject: Mount kdump nfs targets before trying to use them ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/33439/2/src/ovirt/node/config/defaults.py File src/ovirt/node/config/defaults.py: Line 1131: utils.process.check_call(["mount", "-t", "nfs", nfs, Line 1132: tmpdir]) Line 1133: except utils.process.CalledProcessError: Line 1134: self.logger.warning("Failed to mount %s at %s" % (nfs, Line 1135: tmpdir)) Please add exc_info=True to the warning() to have some dbugging informations Line 1136: Line 1137: class UmountNFS(utils.Transaction.Element): Line 1138: title = "Umounting NFS volume" Line 1139: Line 1140: def commit(self): Line 1141: try: Line 1142: utils.process.check_call(["umount", nfs]) Line 1143: except utils.process.CalledProcessError: Line 1144: self.logger.warning("Failed to umount %s" % nfs) See above for adding exc_info Line 1145: Line 1146: class CreateNfsKdumpConfig(utils.Transaction.Element): Line 1147: title = "Creating kdump NFS config" Line 1148: -- To view, visit http://gerrit.ovirt.org/33439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b64094fe1c42638eac00ad81c79c043b884a528 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
