Fabian Deutsch has posted comments on this change. Change subject: Additional input parameter check to persist and unpersist function in fs utils. Passing None as path will no longer cause for a crash. ......................................................................
Patch Set 3: (1 comment) Patch is good. Just the msg needs one more update. http://gerrit.ovirt.org/#/c/35749/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-01 14:54:48 +0200 Line 4: Commit: Tolik Litovsky <[email protected]> Line 5: CommitDate: 2014-12-01 17:11:40 +0200 Line 6: Line 7: Additional input parameter check to persist and unpersist function in fs Please add a new-line between the Title (first line) and the first description line(should be in the third line). Otherwise gitk and other tools will start to cry .. Line 8: utils. Passing None as path will no longer cause for a crash. Line 9: Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154356 Line 11: Change-Id: Icd6a0010e4ffdfd92b83506f1809ff54f5f40e10 -- To view, visit http://gerrit.ovirt.org/35749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd6a0010e4ffdfd92b83506f1809ff54f5f40e10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
