Fabian Deutsch has posted comments on this change. Change subject: installer: Only add mapth.wwid once ......................................................................
Patch Set 2: Code-Review-2 (1 comment) http://gerrit.ovirt.org/#/c/36301/2/src/ovirtnode/install.py File src/ovirtnode/install.py: Line 571: 2. pass wwid of root device on kernel cmdline Line 572: I choose 2 because it seems to be less invasive. Line 573: https://bugzilla.redhat.com/show_bug.cgi?id=1152948 Line 574: """ Line 575: wwidcmd = "multipath -ll | egrep -o '^.*dm-[0-9]' | cut -d' ' -f1" This must include the device! "multipath -ll %s | …" % self.disk Line 576: logger.debug("We are on el7, checking for multipath: %s" % wwidcmd) Line 577: wwidproc = _functions.subprocess_closefds(wwidcmd, shell=True, Line 578: stdout=subprocess.PIPE, Line 579: stderr=subprocess.STDOUT) -- To view, visit http://gerrit.ovirt.org/36301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbe05082b62a5ec39f14755e377679f45e7966f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
