Anatoly Litovsky has posted comments on this change. Change subject: Allowing code to be run from jenkins where there is no terminal that runs the job. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36415/1/tools/edit-node File tools/edit-node: Line 153: Line 154: self.skip_minimize = False Line 155: """Controls whether an image minimizing snapshot should be created.""" Line 156: Line 157: self._builder = os.environ['LOGNAME'] > os.getlogin() should work in F21. Are you facing any issue on it? yes. It doesnt work with out terminal. So in order for it to run on jenkins with out terminal . Needed to change it. Line 158: """The name of the Remix builder for _branding. Line 159: Default = os.getlogin()""" Line 160: Line 161: self._isofstype = "iso9660" Line 181: """directory where the iso is staged""" Line 182: Line 183: self.ks = None Line 184: """optional kickstart file as a recipe for editing the image""" Line 185: > space. Done Line 186: self._ImageCreator__fstype = "ext4" Line 187: Line 188: self._ImageCreator__selinux_mountpoint = "/sys/fs/selinux" Line 189: with open("/proc/self/mountinfo", "r") as f: -- To view, visit http://gerrit.ovirt.org/36415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie25e0827a51df92dec58c7d6f052663bcea9c297 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
