Fabian Deutsch has posted comments on this change. Change subject: Addopting to jenkins ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36414/1/tools/edit-node File tools/edit-node: Line 1533: dest="releasefile", Line 1534: help="Specify release file/s for branding.") Line 1535: Line 1536: parser.add_option("-b", "--builder", type="string", Line 1537: dest="builder", default=os.environ['LOGNAME'], Please use os.environ.get("LOGNAME", None) (if environ is a dict). But maybe environ[…] has different semnatics than a dict... Line 1538: help="Specify the builder of a Remix.") Line 1539: Line 1540: parser.add_option("-p", "--install-plugin", type="string", Line 1541: dest="plugin", help="comma delimited list of plugins " + -- To view, visit http://gerrit.ovirt.org/36414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I351508d7b6dd42bfbfdf6a3b0aa2c051d8c040d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
