Fabian Deutsch has posted comments on this change. Change subject: Don't add callbacks to the queue if they're None ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/35607/1/src/ovirt/node/ui/urwid_builder.py File src/ovirt/node/ui/urwid_builder.py: Line 465: callback To prevent indentation, please change the logic to: if not callback: self.logger.debug("Won't call a None callback") return .... -- To view, visit https://gerrit.ovirt.org/35607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1635275fab0c087114872c558446b790e4b2fe6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
