Fabian Deutsch has posted comments on this change. Change subject: Fixing minimizer dependency between el6 and other distros ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38750/1/ovirt-node.spec.in File ovirt-node.spec.in: Line 155: Line 156: %if 0%{with_minimizer} Line 157: Requires: ovirt-node-minimizer Line 158: %endif Line 159: The livecd related dependencies are closely related to this, please pull them into this conditional, e.g.: if with_minimizre … else if centos … else … endif endif We can even drop the inner if. Line 160: Requires: libselinux-python Line 161: Line 162: %define tools_root %{_datadir}/ovirt-node-tools Line 163: -- To view, visit https://gerrit.ovirt.org/38750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dc3c56b816aa31cea835284a2c299140a3de6bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
