Fabian Deutsch has posted comments on this change. Change subject: defaults: use the same hostname validators as valid ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/36305/2/src/ovirt/node/config/defaults.py File src/ovirt/node/config/defaults.py: Line 708: keys = ("OVIRT_HOSTNAME",) Line 709: Line 710: @NodeConfigFileSection.map_and_update_defaults_decorator Line 711: def update(self, hostname): Line 712: (valid.Empty() | valid.HostnameLength())(hostname) Replacing the validator /FQDN… with …Length) means that all the other hostname restrictions will not be checked. A better solution might be to do the hostname length check in the FQDNOrIPAddress validator. Line 713: Line 714: def transaction(self): Line 715: cfg = self.retrieve() Line 716: hostname = cfg["hostname"] -- To view, visit https://gerrit.ovirt.org/36305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cfa671656b622956aafd6020b37a987cbef1fcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
