Fabian Deutsch has posted comments on this change. Change subject: valid: add to FQDNOrIPAddress, HostnameLength validation ......................................................................
Patch Set 3: Code-Review-1 (1 comment) One nit pick https://gerrit.ovirt.org/#/c/38950/3/src/ovirt/node/valid.py File src/ovirt/node/valid.py: Line 456: self._validator = FQDN() | IPAddress(allow_ipv6) Line 457: self.description = self._validator.description Line 458: Line 459: def validate(self, value): Line 460: if HostnameLength()(value) and self._validator.validate(value): Please change the validator above, in line 456. (…) & HostnameLength() Line 461: return True Line 462: return False Line 463: Line 464: -- To view, visit https://gerrit.ovirt.org/38950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02d907b69a15506ffc9337f642d97a301bf3c9f0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
