Fabian Deutsch has posted comments on this change.

Change subject: Enabling build system to build from online packages only on 
master
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/39335/1/Makefile.am
File Makefile.am:

Line 30: ARCH              = $(shell rpm --eval '%{_arch}')
Line 31: RELEASE                  := $(shell rpm -q --qf "%{RELEASE}\n" 
--define "BUILD_NUMBER $(BUILD_NUMBER)" --specfile ./ovirt-node-iso.spec | head 
-n1)
Line 32: RECIPE_DIR               = @RECIPES@
Line 33: OVIRT_VERSION     = @PACKAGE_VERSION@
Line 34: REPO_SUFIX        = @REPO_SUFIX@
Should be SUFFIX
Line 35: 
Line 36: OVIRT_CACHE_DIR        ?= $(HOME)/ovirt-caches
Line 37: 
Line 38: EXTRA_DIST = \


https://gerrit.ovirt.org/#/c/39335/1/recepie-downloader.sh.in
File recepie-downloader.sh.in:

Line 4: OVIRT_REPO_SUFIX
Should be SUFFIX


-- 
To view, visit https://gerrit.ovirt.org/39335
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ef5d95156355306a68f67b8f71fe74f8b1dee59
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-iso
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to