Fabian Deutsch has posted comments on this change. Change subject: Add on-shutdown hooks ......................................................................
Patch Set 1: (2 comments) See my inline comments https://gerrit.ovirt.org/#/c/39730/1/hooks/on-shutdown/01-save-virtwho.py File hooks/on-shutdown/01-save-virtwho.py: Line 19: for f in glob("/etc/virt-who.d/*"): Line 20: try: Line 21: Config().persist(f) Line 22: except: Line 23: "Couldn't persist {f}!".format(f=f) Shouldn't this err get printed? https://gerrit.ovirt.org/#/c/39730/1/services/ovirt-node-hooks.service File services/ovirt-node-hooks.service: Line 7: [Service] Line 8: Type=oneshot Line 9: RemainAfterExit=yes Line 10: ExecStart=/usr/libexec/ovirt-node-hooks trigger on-boot Line 11: ExecStop=/usr/libexec/ovirt-node-hooks trigger on-shutdown Should we maybe create a separate service which is run after a reboot or poweroff target? Line 12: Line 13: [Install] -- To view, visit https://gerrit.ovirt.org/39730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cc830b1b4b28db29a3fe995ac31c36b15cf6676 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
