Fabian Deutsch has posted comments on this change.

Change subject: Tweak edit-node's naming
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/33680/1/tools/edit-node
File tools/edit-node:

Line 1725:     >>> isoname_to_nvr(fn)
Line 1726:     ('rhev-hypervisor7', '7.0', '20140926.0', 'dummyarch', 
'dummydist')
Line 1727:     """
Line 1728:     newfn = re.sub("\.(iso)$", "", isofilename)
Line 1729:     if not re.search(r'(\.fc\d+\.?)|(\.el\d\.?)', newfn):
We might need to cover el6ev (note the ev) here.
Line 1730:         newfn += ".dummydist"
Line 1731:     newfn += ".dummyarch"
Line 1732:     return filename_to_nvra(newfn)
Line 1733: 


-- 
To view, visit https://gerrit.ovirt.org/33680
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a734b449e337992d51068248c4701ac2f7a40c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to