Ryan Barry has uploaded a new change for review. Change subject: Add a minimum data size ......................................................................
Add a minimum data size Set the minimum data size to 10GB, since small data sizes cause interesting problems with registration and interactions with the engine Change-Id: I018fd1a34e60ec95b89092e8c3b21a8a12109293 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133180 Signed-off-by: Ryan Barry <[email protected]> --- M src/ovirt/node/installer/core/storage_vol_page.py M src/ovirtnode/storage.py 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/38/40638/1 diff --git a/src/ovirt/node/installer/core/storage_vol_page.py b/src/ovirt/node/installer/core/storage_vol_page.py index 6bc502a..e280510 100644 --- a/src/ovirt/node/installer/core/storage_vol_page.py +++ b/src/ovirt/node/installer/core/storage_vol_page.py @@ -52,7 +52,7 @@ return self._model def validators(self): - min_swap, min_logging = self.__get_min_sizes() + min_swap, min_logging, min_data = self.__get_min_sizes() return {"storage.efi_size": valid.Number(bounds=[0, None]), "storage.root_size": @@ -64,7 +64,7 @@ "storage.logging_size": valid.Number(bounds=[min_logging, None]), "storage.data_size": - valid.Number(bounds=[-1, None]), + valid.Number(bounds=[min_data, None]), } def ui_content(self): @@ -156,10 +156,10 @@ def __get_min_sizes(self): if self.application.args.dry: - return 2048, 256 + return 2048, 256, 10*1024 from ovirtnode.storage import Storage stor = Storage() - return stor.MIN_SWAP_SIZE, stor.MIN_LOGGING_SIZE + return stor.MIN_SWAP_SIZE, stor.MIN_LOGGING_SIZE, stor.MIN_DATA_SIZE def __get_default_sizes(self): if self.application.args.dry: diff --git a/src/ovirtnode/storage.py b/src/ovirtnode/storage.py index 0ed9500..b0da03c 100644 --- a/src/ovirtnode/storage.py +++ b/src/ovirtnode/storage.py @@ -44,6 +44,7 @@ self.EFI_SIZE = 256 self.SWAP_SIZE = 0 self.MIN_SWAP_SIZE = 5 + self.MIN_DATA_SIZE = 10*1024 self.MIN_LOGGING_SIZE = 5 self.SWAP2_SIZE = 0 self.DATA2_SIZE = 0 -- To view, visit https://gerrit.ovirt.org/40638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I018fd1a34e60ec95b89092e8c3b21a8a12109293 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
