Fabian Deutsch has posted comments on this change. Change subject: Fix the text for netmask validators ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Looks good in general, but one note https://gerrit.ovirt.org/#/c/40637/1/src/ovirt/node/valid.py File src/ovirt/node/valid.py: Line 438: description = "a valid IPv6 address" Line 439: family = socket.AF_INET6 Line 440: Line 441: Line 442: class Netmask(IPv4Address): Please rename it to IPv4Netmask to prevent collissions with eventual other IP versions, i.e. 6 Line 443: """ Validates dot.decimal netmasks Line 444: Line 445: >>> Netmask()("255.255.255.0") Line 446: True -- To view, visit https://gerrit.ovirt.org/40637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25856f1a6df4c926063b8b5efc2807e73771d416 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
