Fabian Deutsch has submitted this change and it was merged. Change subject: ovirt-node-upgrade: set ret statement correctly ......................................................................
ovirt-node-upgrade: set ret statement correctly Move the ret statement equals 0 (non error) when upgrade action is executed sucessfully instead of call it on the finally clause which might hide real issues on tools outside ovirt-node-upgrade. Change-Id: Ia18a7d3b27c01001d47f8a91c59dc33d218f0c57 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182089 Signed-off-by: Douglas Schilling Landgraf <[email protected]> (cherry picked from commit 8f25a30a1572e42ec2b7ffba27f5afe4df3e9ad5) --- M scripts/ovirt-node-upgrade.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia18a7d3b27c01001d47f8a91c59dc33d218f0c57 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
