Douglas Schilling Landgraf has posted comments on this change. Change subject: Add a warning about the appliance if the data size is too small ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40673/1/src/ovirt/node/installer/core/confirmation_page.py File src/ovirt/node/installer/core/confirmation_page.py: Line 90: )) Line 91: row = ui.Row("row[%s]" % xs, chi) Line 92: ws.append(row) Line 93: Line 94: if int(self._model["storage.data_size"]) < (50*1024): Hey Ryan, can we have the 50G as a constant in the preset.py? Line 95: ws.extend([ui.Divider("divider.he"), Line 96: ui.Notice("notice.he", "The size of the data volume is " Line 97: "not large enough to use the Engine " Line 98: "Appliance, must be at least 50GB (51200MB)")]) -- To view, visit https://gerrit.ovirt.org/40673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37641342c0ef5eec9781e769c8f42ac14fc056f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
