Fabian Deutsch has posted comments on this change. Change subject: Add system.Filesystem.by_partlabel ......................................................................
Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/34912/5/src/ovirt/node/utils/system.py File src/ovirt/node/utils/system.py: Line 890: fs = Filesystem(device) Line 891: Line 892: except process.CalledProcessError as e: Line 893: LOGGER.debug("Failed to resolve disks: %s" % e.cmd, exc_info=True) Line 894: return fs You should return Filesystem(fs) here Line 895: Line 896: def _tokens(self): Line 897: tokens = process.check_output(["blkid", "-o", "export", self.device]) Line 898: return parse_varfile(tokens) -- To view, visit https://gerrit.ovirt.org/34912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I531adfce70f1a0f4977d454d8447315f2e2bea46 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
