Fabian Deutsch has posted comments on this change. Change subject: ntpd: condition for start ......................................................................
Patch Set 1: (1 comment) Yes, in general a great clean solution. Just one nitpick. https://gerrit.ovirt.org/#/c/41812/1/src/ovirt/node/setup/core/network_page.py File src/ovirt/node/setup/core/network_page.py: Line 159: if nameservers: Line 160: for idx, nameserver in enumerate(nameservers): Line 161: model["dns[%d]" % idx] = nameserver Line 162: Line 163: if os.path.exists(utils.fs.Config()._config_path("/etc/ntp.conf")): This can be Config().exists(fn) Line 164: timeservers = config.network.timeservers() Line 165: if timeservers: Line 166: for idx, timeserver in enumerate(timeservers): Line 167: model["ntp[%d]" % idx] = timeserver -- To view, visit https://gerrit.ovirt.org/41812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebee8a8581fd0b51d07bde04b1f878a1cb5481ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
