Fabian Deutsch has posted comments on this change. Change subject: defaults: Add vdsmd to stop/start in network conf ......................................................................
Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/42239/3/src/ovirt/node/config/defaults.py File src/ovirt/node/config/defaults.py: Line 279: def transaction(self): Line 280: """Return all transactions to re-configure networking Line 281: """ Line 282: services = ["network", "ntpd", "ntpdate", "rpcbind", "nfslock", Line 283: "rpcidmapd", "nfs-idmapd", "rpcgssd", "vdsmd"] The only reason why I do not like this is because ovirt-node should not know about vdsm - but otoh there is no other easy solution, thus it's ok. Line 284: Line 285: def do_services(cmd, services): Line 286: with console.CaptureOutput(): Line 287: for name in services: -- To view, visit https://gerrit.ovirt.org/42239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11808417c8358777478f0cf9f821d93cafbb9f3b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
