Fabian Deutsch has submitted this change and it was merged. Change subject: Rework detection of multipath disks to remove in the installer ......................................................................
Rework detection of multipath disks to remove in the installer Checking whether "somestring" in "somestring" leads to bad results when we check if "sda" is part of "sdaa sdab...". Don't spuriously remove valid disks. Use a dict instead and check against that. Log the original output, just in case it's ever needed anywhere. Also, use a set to ensure unique values instead of looping through and decrementing the count. Change-Id: I20be68e232e25e9a751516edbaece69c0b81107d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203176 Signed-off-by: Ryan Barry <[email protected]> --- M src/ovirtnode/storage.py 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20be68e232e25e9a751516edbaece69c0b81107d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
