Fabian Deutsch has posted comments on this change. Change subject: confirmation_page: Do not compare strings and numbers ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43174/1/src/ovirt/node/installer/core/confirmation_page.py File src/ovirt/node/installer/core/confirmation_page.py: Line 91: )) Line 92: row = ui.Row("row[%s]" % xs, chi) Line 93: ws.append(row) Line 94: Line 95: dsize = int(re.sub('[^0-9]', '', self._model["storage.data_size"])) How can it happen that there are other than 0-9 chars? Line 96: if dsize < (50*1024): Line 97: ws.extend([ui.Divider("divider.he"), Line 98: ui.Notice("notice.he", "The size of the data volume is " Line 99: "not large enough to use the Engine " -- To view, visit https://gerrit.ovirt.org/43174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I700a4aed2f7c11cb5081377d65bc622e0a5e1f32 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
