Fabian Deutsch has posted comments on this change. Change subject: module: persist/unpersist module should raise ......................................................................
Patch Set 8: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/43044/8/scripts/persist File scripts/persist: Line 40: if conf.exists(path): Line 41: print "Already persisted: %s" % path Line 42: continue Line 43: Line 44: try: The try/except block is not needed as you raise it anyway Line 45: ret_persist = conf.persist(path) Line 46: except Exception: Line 47: raise Line 48: https://gerrit.ovirt.org/#/c/43044/8/scripts/unpersist File scripts/unpersist: Line 39: if not conf.exists(path): Line 40: print "File not explicitly persisted: %s" % path Line 41: continue Line 42: Line 43: try: The try/except block is not needed as you raise it anyway Line 44: ret_unpersist = conf.unpersist(path) Line 45: except Exception: Line 46: raise Line 47: -- To view, visit https://gerrit.ovirt.org/43044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a917b2476957ef31e5ff452bfb01a4152b44f51 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
