Fabian Deutsch has posted comments on this change. Change subject: defaults: only set hostname if it's required ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43754/2/src/ovirt/node/config/defaults.py File src/ovirt/node/config/defaults.py: Line 735: idx = _idx + 1 Line 736: p = "%s/alias[%s]" % (localhost_entry, idx) Line 737: aug.set(p, alias, False) Line 738: Line 739: if self.hostname: This does not look right to me. We need to see if /etc/hostname is still used in el7. If it's not used anymore, then let's just drop that logic (specific to th e/etc/hostname file) all together. Line 740: config.network.hostname(self.hostname) Line 741: fs.Config().persist("/etc/hostname") Line 742: Line 743: fs.Config().persist("/etc/hosts") -- To view, visit https://gerrit.ovirt.org/43754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idebfed15f63111ddc9b36ec09619b0f685b8394b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
