Fabian Deutsch has posted comments on this change. Change subject: Add make targets for snapshot RPMs for nightlies, use those ......................................................................
Patch Set 1: Code-Review-1 Verified+1 (2 comments) https://gerrit.ovirt.org/#/c/43953/1/Makefile.am File Makefile.am: Line 59: @echo Line 60: @echo "rpm(s) available at '$(TMPREPOS)'" Line 61: @echo Line 62: Line 63: snapshot-rpm: srpm There is already a target named snapshot-rpm further down that file, please merge with or remove it. Also see if the snapshot target can be resued, because that target is used for publishing the source tarballs (of snapshots). Line 64: $(RPMBUILD_ARGS) += 'RELEASE_SUFFIX=".$(date --utc +%Y%m%d).git$(git rev-parse --short HEAD)"' Line 65: $(RPMBUILD) $(RPMBUILD_ARGS) -ts "$(PACKAGE_TARNAME)-$(PACKAGE_VERSION).tar.gz" Line 66: @echo Line 67: @echo "rpm(s) available at '$(TMPREPOS)'" Line 60: @echo "rpm(s) available at '$(TMPREPOS)'" Line 61: @echo Line 62: Line 63: snapshot-rpm: srpm Line 64: $(RPMBUILD_ARGS) += 'RELEASE_SUFFIX=".$(date --utc +%Y%m%d).git$(git rev-parse --short HEAD)"' Please include the hours, minutes, and seconds as well - because we can have more than one job per day. Line 65: $(RPMBUILD) $(RPMBUILD_ARGS) -ts "$(PACKAGE_TARNAME)-$(PACKAGE_VERSION).tar.gz" Line 66: @echo Line 67: @echo "rpm(s) available at '$(TMPREPOS)'" Line 68: @echo -- To view, visit https://gerrit.ovirt.org/43953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7835d2b261375a8c9d0e1393107c139cb7bdc94d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
