Fabian Deutsch has submitted this change and it was merged. Change subject: Clean up rhn_page ......................................................................
Clean up rhn_page Move all the standalone functions into the model. Remove unecessary imports. Get rid of some constants. Slight logic cleanup instead of concatenating strings. Doesn't need to be that dynamic. Sacrifice dynamic to gain readability, we can always add it back later if we need it. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1247202 Change-Id: Ide8dec4c91464a3c4a54a19890b3806b318f308a Signed-off-by: Ryan Barry <[email protected]> --- M src/ovirt/node/setup/rhn/rhn_page.py 1 file changed, 61 insertions(+), 134 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/40242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide8dec4c91464a3c4a54a19890b3806b318f308a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
