Douglas Schilling Landgraf has posted comments on this change. Change subject: Providing correct path to fingerprint keyes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44323/1/scripts/ovirt-init-functions.sh.in File scripts/ovirt-init-functions.sh.in: Line 1522: log "Running handler: $handler" Line 1523: runcon -t unconfined_t "$handler" 2>&1 Line 1524: done Line 1525: fi Line 1526: I would prefer a loop here looking for files following ssh_host*_key* format and if it exists ovirt_store_config it. The current approach will explode in case there is no ssh_host*_key* file. Line 1527: ovirt_store_config $(ls /etc/ssh/ssh_host*_key*) Line 1528: Line 1529: # FIXME is this still needed? Line 1530: if is_standalone; then -- To view, visit https://gerrit.ovirt.org/44323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8466ccabc143e41b1507d5020664a0a05e5c784 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
