Douglas Schilling Landgraf has posted comments on this change. Change subject: Avoiding displaying vdsmdummy network ......................................................................
Patch Set 1: Code-Review-1 (3 comments) minor comments. https://gerrit.ovirt.org/#/c/48244/1/src/ovirt/node/setup/core/network_page.py File src/ovirt/node/setup/core/network_page.py: Line 90: nics = model.nics(filter_slaveless=True, Line 91: filter_configured=filter_configured) Line 92: for name, nic in sorted(nics.items()): Line 93: if nic.ifname.startswith(";"): Line 94: continue Looks good. Line 95: if first_nic is None: Line 96: first_nic = name Line 97: if has_managed_ifnames(): Line 98: is_cfg = "Managed" Line 97: if has_managed_ifnames(): Line 98: is_cfg = "Managed" Line 99: else: Line 100: is_cfg = ("Configured" if nic.is_configured() else Line 101: "Unconfigured") pep8 won't be happy with this change. My suggestion is leave as it's. Line 102: Line 103: fields = self.__build_fields(nic, is_cfg, has_managed_ifnames(), Line 104: system.has_systemd()) Line 105: Line 100: is_cfg = ("Configured" if nic.is_configured() else Line 101: "Unconfigured") Line 102: Line 103: fields = self.__build_fields(nic, is_cfg, has_managed_ifnames(), Line 104: system.has_systemd()) pep8 won't be happy with this change. My suggestion is leave as it's. Line 105: Line 106: description = " ".join(fields) Line 107: Line 108: node_nics.append((name, description)) -- To view, visit https://gerrit.ovirt.org/48244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id378a054241fa9d4559b2ef6376af7f96bd68474 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: refs/master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
