Fabian Deutsch has posted comments on this change. Change subject: [rhn] Don't try to unpersist files unless they're persisted ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48035/1/src/ovirt/node/setup/rhn/rhn_model.py File src/ovirt/node/setup/rhn/rhn_model.py: Line 286: title = "Removing old configuration" Line 287: Line 288: def commit(self): Line 289: def scrub(f): Line 290: if Config().exists(f): Please fix the root cause in Config.unpersist() so that unpersist can be called on non-persisted files and doesn't do harm Line 291: Config().unpersist(f) Line 292: # Unlinking causes problems with satellite5. Why? Line 293: # os.unlink(f) Line 294: # find old SAM/Sat 6 registrations -- To view, visit https://gerrit.ovirt.org/48035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16267d0d5ebd104fc85b174c7b86df3a2d4724d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
