Fabian Deutsch has posted comments on this change. Change subject: Be smarter about failed RHNSM/Satellite registrations ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48515/1/src/ovirt/node/setup/rhn/rhn_page.py File src/ovirt/node/setup/rhn/rhn_page.py: Line 111: rhntype = rhntype.title() Line 112: else: Line 113: rhntype = rhntype.upper() Line 114: Line 115: try: I'd suggest to factor this out into a function to not bloat the existing function even more. Line 116: cmd = ["subscription-manager", "status"] Line 117: process.check_call(cmd) Line 118: rhn_msg = "RHNSM Registration\n\nRegistration Status: %s" \ Line 119: % rhntype -- To view, visit https://gerrit.ovirt.org/48515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied4c2774ab4c36b1d612fbf765f87e315adf73ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
