Fabian Deutsch has posted comments on this change. Change subject: Persist all of /var/lib/net-snmp instead of just snmpd.conf ......................................................................
Patch Set 3: (1 comment) Is patchset 5 the correct patchset? I'm missing the persistence of the complete directory. https://gerrit.ovirt.org/#/c/46533/3/src/ovirt/node/setup/snmp/snmp_model.py File src/ovirt/node/setup/snmp/snmp_model.py: Line 68: process.check_call(["cp", "/etc/snmp/snmpd.conf", "/tmp"]) Line 69: process.check_call("sed -c -ie '/^createUser root/d' %s" % snmp_conf, Line 70: shell=True) Line 71: configs = [snmp_conf, old_conf] Line 72: [fs.Config().unpersist(c) for c in configs if fs.Config().exists(c)] > This is desirable since upgraded systems will have the old configs persiste Right, that sounds reasonable. Line 73: Line 74: Line 75: class SNMP(NodeConfigFileSection): Line 76: """Configure SNMP -- To view, visit https://gerrit.ovirt.org/46533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifef49615cca8eae9107d3ea409db30f71c2815ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
