Douglas Schilling Landgraf has posted comments on this change. Change subject: utils/network: NIC() set config.bridge ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49051/1/src/ovirt/node/utils/network.py File src/ovirt/node/utils/network.py: Line 358: Line 359: def __init__(self, snic): Line 360: super(BridgedNIC, self).__init__(snic.ifname) Line 361: self.slave_nic = snic Line 362: self.bridge_nic = NIC(snic.ifname) > This might fix the problem. But it's also changing the semantics of slef.br Fabian, my understanding is that caller has passed as snic in param the ovirtmgmt interface. The /etc/sysconfig/ifcfg-ovirtmgmt has not BRIDGED="value" as it's the bridge config and there is no pointers in cfg file to ens3 or whatever interface. i.e.: ./usr/lib/python2.7/site-packages/ovirt/node/utils/network.py if layout == "bridged": self.logger.debug(" Is bridged") nic = BridgedNIC(nic) Line 363: self.config = self.bridge_nic.config Line 364: Line 365: def exists(self): Line 366: return self.bridge_nic.exists() -- To view, visit https://gerrit.ovirt.org/49051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia680a3ed97b3352dfe07f8653010df20a53f3683 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
