Douglas Schilling Landgraf has posted comments on this change.
Change subject: Sometimes BridgedNIC gets called with a bridge. Be smarter
......................................................................
Patch Set 3:
Ryan, the patch looks like work great in the status page but I dropped in the
menu for network page to see the interfaces managed, I see the below error:
File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 786, in
_loop
self._watch_files[fd]()
File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 387, in
_update
self.process_input(keys)
File "/usr/lib64/python2.7/site-packages/urwid/main_loop.py", line 487, in
process_input
k = self._topmost_widget.keypress(self.screen_size, k)
File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1102, in
keypress
return self.body.keypress( (maxcol, remaining), key )
File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1559, in
keypress
key = self.focus.keypress(tsize, key)
File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2240, in
keypress
key = w.keypress((mc,) + size[1:], key)
File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 1559, in
keypress
key = self.focus.keypress(tsize, key)
File "/usr/lib64/python2.7/site-packages/urwid/container.py", line 2240, in
keypress
key = w.keypress((mc,) + size[1:], key)
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 1000, in
keypress
return actual_key(self._keypress_down((maxcol, maxrow)))
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 1108, in
_keypress_down
row_offset, 'above')
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 842, in
change_focus
self.body.set_focus(position)
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 179, in
set_focus
self._modified()
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 159, in
_modified
ListWalker._modified(self)
File "/usr/lib64/python2.7/site-packages/urwid/listbox.py", line 41, in
_modified
signals.emit_signal(self, "modified")
File "/usr/lib64/python2.7/site-packages/urwid/signals.py", line 120, in emit
result |= bool(callback(*args_copy))
File "/usr/lib/python2.7/site-packages/ovirt/node/ui/widgets.py", line 347,
in __on_item_change
urwid.emit_signal(self, "changed", plugin)
File "/usr/lib64/python2.7/site-packages/urwid/signals.py", line 120, in emit
result |= bool(callback(*args_copy))
File "/usr/lib/python2.7/site-packages/ovirt/node/ui/urwid_builder.py", line
495, in menu_item_changed
self.application.switch_to_plugin(plugin)
File "/usr/lib/python2.7/site-packages/ovirt/node/app.py", line 243, in
switch_to_plugin
content = plugin.ui_content()
File
"/usr/lib/python2.7/site-packages/ovirt/node/setup/core/network_page.py", line
221, in ui_content
NicTable("nics", height=3),
File
"/usr/lib/python2.7/site-packages/ovirt/node/setup/core/network_page.py", line
51, in __init__
self._get_nics(filter_configured),
File
"/usr/lib/python2.7/site-packages/ovirt/node/setup/core/network_page.py", line
94, in _get_nics
if nic.ifname.startswith(";"):
AttributeError: 'NoneType' object has no attribute 'startswith'
--
To view, visit https://gerrit.ovirt.org/51560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e99a015ff5904bfccd4c0d1655d5489776a28dd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
