Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Sometimes BridgedNIC gets called with a bridge. Be smarter ......................................................................
Sometimes BridgedNIC gets called with a bridge. Be smarter Previously, if BridgedNIC was called with an actual bridge as the argument (ovirtmgmt, for example), it set null values for some fields, such as the bridge nic, which caused the network to show unconfigured when it actually was. Add a method to Bridges() to find slaves. Add BridgeNIC (essentially BridgedNIC but setting the ifname to the bridge instead of the slave) Called BridgedNIC only if it's a slave. If it's a bridge, call BridgeNIC, and set the ifname appropriately. Check /sys to find the actual slave nic Change-Id: I9f7181d8fea099c6dce9f287c56d85b92afad068 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280241 Signed-off-by: Ryan Barry <[email protected]> Signed-off-by: Douglas Schilling Landgraf <[email protected]> --- M src/ovirt/node/utils/network.py 1 file changed, 26 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7181d8fea099c6dce9f287c56d85b92afad068 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
