Fabian Deutsch has posted comments on this change. Change subject: Bootloader: find grub configs on EFI ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53001/1/src/ovirt/node/utils/system.py File src/ovirt/node/utils/system.py: I appreciate the generic approach - but it's a too risky patch at this point in time. Can this be created less invasive? I.e. maybe just adding a separate branch for the efi casE: if is_efi: new efi logic else: # leave as is because we know it works on bios The main reason is risk mitigation Line 1: #!/usr/bin/python Line 2: # -*- coding: utf-8 -*- Line 3: # Line 4: # system.py - Copyright (C) 2012 Red Hat, Inc. -- To view, visit https://gerrit.ovirt.org/53001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id837e7932c1c36f08c1dd9a9c28309f435630545 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
