Fabian Deutsch has posted comments on this change.

Change subject: install.py: determine the kernel using uname -r
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

https://gerrit.ovirt.org/#/c/56831/1/src/ovirtnode/install.py
File src/ovirtnode/install.py:

Line 742: 
Line 743:             for path in ["etc", "dev", "proc", "sys", "tmp", "run", 
"var/tmp"]:
Line 744:                 mnts += [rbind(path)]
Line 745: 
Line 746:             upd_kver = str(_functions.passthrough("uname -r")).strip()
This will not work inside of edit-node,

IIUIC uname -r is looking at the running kernel of the host which can differ 
from the kernel of the iso.
Line 747: 
Line 748:             # Update initramfs to pickup multipath wwids
Line 749:             # Let /boot point to the filesystem on the update 
candidate partition
Line 750:             builder = _system.Initramfs(dracut_chroot=updfs, 
boot_source=isomnt)


-- 
To view, visit https://gerrit.ovirt.org/56831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7787a9e3e6bc0b6c5ca7a257f8668a599357cd79
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to