Douglas Schilling Landgraf has posted comments on this change. Change subject: fs/__init__.py: check if it's a file before chksum ......................................................................
Patch Set 4: Code-Review+2 Continuous-Integration+1 (1 comment) https://gerrit.ovirt.org/#/c/56508/3/src/ovirt/node/utils/fs/__init__.py File src/ovirt/node/utils/fs/__init__.py: Line 686: # Check that the files exist Line 687: exists &= os.path.exists(persisted_path) Line 688: exists &= os.path.exists(filename) Line 689: Line 690: if exists and check_is_in_sync and os.path.isfile(filename): > But filename can be a dir. Done Line 691: # If requested, also check that the contents match Line 692: current_checksum = self.checksum(filename) Line 693: stored_checksum = self.checksum(persisted_path) Line 694: exists &= stored_checksum == current_checksum -- To view, visit https://gerrit.ovirt.org/56508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a50dca7521336a9feafbc6c03fa38e1a57a6ba9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
