On Tue, Apr 3, 2012 at 17:39, Jérémy Lal <[email protected]> wrote:
> On 03/04/2012 15:04, Ben Noordhuis wrote:
>> On Tue, Apr 3, 2012 at 11:02, Jérémy Lal <[email protected]> wrote:
>>> Hi,
>>> i built nodejs 0.6.14 with libv8 3.8.9.16 (which supports mips little 
>>> endian),
>>> and ran the "test/simple" suite on this architecture :
>>> http://db.debian.org/machines.cgi?host=rem
>>>
>>> There is only one failing test (test-readfloat), see
>>> https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=mipsel&ver=0.6.14~dfsg1-1&stamp=1333442457&file=log
>>>
>>> It's worth trying to solve it, no ?
>>>
>>> Jérémy.
>>
>> Curious that simple/test-readdouble passes but simple/test-readfloat
>> doesn't. Last time I ran the test suite on MIPS, a number of tests
>> failed but not that one (IIRC). Can you try this patch?
>>
>> diff --git a/lib/buffer.js b/lib/buffer.js
>> index a0210b9..a5b462d 100644
>> --- a/lib/buffer.js
>> +++ b/lib/buffer.js
>> @@ -249,7 +249,7 @@ function Buffer(subject, encoding, offset) {
>>        if (!pool || pool.length - pool.used < this.length) allocPool();
>>        this.parent = pool;
>>        this.offset = pool.used;
>> -      pool.used += this.length;
>> +      pool.used = (pool.used + this.length + 7) & ~7;
>>      }
>>
>>      // Treat array-ish objects as a byte array.
>
> Commit 285d8c65 was already applied for that build.
> This patch you give is slightly different, though.
>
> I hope i will soon have ssh access to a mips(el) machine,
> for now i can only see the results of a build server.

Oh, in that case don't bother. It's the same concept, only expressed
more succinctly. I'll see if I can dig up my old MIPS router.

-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

Reply via email to