I'm pretty sure its legit as long as the module's build is organized in such a way as to provide the binaries/link the binaries as a fallback and not necessarily as a first option. i.e, if the module can compile natively, it should do so, but otherwise if it cannot, see if there is a supported binary for the system, and then include/link that.
On Fri, May 4, 2012 at 7:11 PM, mscdex <[email protected]> wrote: > On May 4, 6:58 pm, Marcel Laverdet <[email protected]> wrote: > > But is someone going to beat me up if I stick a bunch of compiled > binaries > > into npm? > > Probably not, but it might depend on how easy it is to compile the > binary on Windows. > > For example, my mmmagic module depends on libmagic which has a lot of > *nix-specific stuff and would take more time than I have to create a > floating patch for it to build easily under msvc. So what I ended up > doing as a workaround was to compile it under mingw (as a static lib) > and then link that to my addon. Since this requires much more than > just "install vc2010 express" (e.g. also requiring a proper mingw > setup, etc), IMHO it's well worth making a pre-compiled version of the > addon for Windows users. > > Also, I think it'd be nice to let non-Windows users compile from > scratch (if possible), mostly because of the varying architectures/ > platforms that node supports. > > That's my 2 cents. > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en > -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
