Yeah, that was quite a loophole. It has kept 'binary' encoding alive for another stable branch, that's for sure.
Expect it to warn in 0.9, and be removed sometime thereafter. The crypto module is a pretty sorry sight. It works just well enough to make everyone not want to do the tedious work of updating it, but it'd be a good task for someone new to the project who wants to get involved. Pretty self-contained, enough work to be relevant, but nothing super complicated. The API just needs a lot of cleanup. On Wed, May 16, 2012 at 1:59 PM, mscdex <[email protected]> wrote: > On May 16, 2:56 pm, Mattias Ernelli <[email protected]> wrote: >> Anyway, found a loophole in the docs, 'binary' strings cannot be removed >> yet, it will break >> crypto:http://nodejs.org/api/crypto.html#crypto_crypto_createcipher_algorith... > > Yeah, although the code does use ASSERT_IS_STRING_OR_BUFFER *after* > the argument type checks in createCipher, which is kind of odd ;-) > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
