On Wednesday, August 15, 2012 10:12:51 PM UTC+2, Alexander Shtuchkin wrote: > > 2. *The* Idle Notification. I've made some research about it in node > codebase. The algorithm was last modified 2 years ago, somewhere around > version 0.1.94 and I think must be updated to reflect current V8 best > practices. I summarized current code here: https://gist.github.com/3363081. > Most evident problem here is that node is sending IdleNotification every 5 > seconds when HeapTotal > 128M no matter what. This exact behavior is making > a lot of node practitioners disable the idle notifications and have better > results when lots of memory is needed (my test showed this very clear). > I'm willing to do a pull request to change this behavior after discussing > here what algorithm should be implemented instead of the current one. >
I think he bigger problem here is that once the idle notification kicks in it keeps running until v8::IdleNotification returns false. In between runs node will do *some* event processing, and some v8 heap allocations happen. Therefore, it's likely that v8::IdleNotification keeps getting called until the server is really idle again (which might never happen). -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
