I agree with Tim Caswell. Lets face it, that exists exists is embarassing. removing it from the docs (replace with a link to stat) but leaving it in the code (with a big comment) is the right compromise. once everyone has forgotten about it, it will be easier to remove it.
I understand isaac's position. he doesn't want to remove exists, because although it's a breaking change, and although we LOVE breaking changes in node, what we really love about breaking changes is when a breaking change is a breaking improvement. but this is only a cosmetic improvement. there will be no associated performance improvement... On Tue, Aug 21, 2012 at 1:11 AM, Stewart Mckinney <[email protected]> wrote: > Yeah, I couldn't agree with Dan more. Consistency is super important, > especially for a core lib. I mean, it could be worse, b ut, it should be > addressed rather than ignored. > > > On Mon, Aug 20, 2012 at 6:37 PM, Dan Milon <[email protected]> wrote: >> >> Thats what PHP thought about deprecation also. See where this got them. >> >> >> On Mon, Aug 20, 2012 at 6:59 PM, Arnout Kazemier <[email protected]> >> wrote: >>> >>> I really dont get why people want to depricate functions just because >>> they dont agree with the api signature. >>> >>> This is a useful function, it doesnt hurt anyone if we keep it, but it >>> does hurt when its removed. >>> >>> On 20 aug. 2012, at 17:53, Tim Caswell <[email protected]> wrote: >>> >>> > How about removing it from the docs and making it non-enumerable in >>> > the fs module. Then any new developers won't know it's there unless >>> > they are reading someone else's code. Or maybe in the docs simply say >>> > that it shouldn't be used and is only left there so as to not break >>> > old code. Also, how is this different from deprecation? >>> > >>> > On Sun, Aug 19, 2012 at 4:02 PM, Bert Belder <[email protected]> >>> > wrote: >>> >> On Sunday, August 19, 2012 8:23:53 PM UTC+2, Nuno Job wrote: >>> >>> >>> >>>>> Maybe a note in the docs tell people that fs.stat is a better >>> >>>>> choice? >>> >>> >>> >>> Good idea Mikeal. Deprecation console.error && pointing people to >>> >>> fs.stat in the docs should do the trick. >>> >> >>> >> >>> >> I don't see enough compelling reasons to deprecate it. I think a doc >>> >> addition that warns people about the funky signature and the >>> >> anti-pattern >>> >> would suffice. >>> >> >>> >> - Bert >>> >> >>> >> >>> >> -- >>> >> Job Board: http://jobs.nodejs.org/ >>> >> Posting guidelines: >>> >> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >>> >> You received this message because you are subscribed to the Google >>> >> Groups "nodejs" group. >>> >> To post to this group, send email to [email protected] >>> >> To unsubscribe from this group, send email to >>> >> [email protected] >>> >> For more options, visit this group at >>> >> http://groups.google.com/group/nodejs?hl=en?hl=en >>> > >>> > -- >>> > Job Board: http://jobs.nodejs.org/ >>> > Posting guidelines: >>> > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >>> > You received this message because you are subscribed to the Google >>> > Groups "nodejs" group. >>> > To post to this group, send email to [email protected] >>> > To unsubscribe from this group, send email to >>> > [email protected] >>> > For more options, visit this group at >>> > http://groups.google.com/group/nodejs?hl=en?hl=en >>> >>> -- >>> Job Board: http://jobs.nodejs.org/ >>> Posting guidelines: >>> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >>> You received this message because you are subscribed to the Google >>> Groups "nodejs" group. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected] >>> For more options, visit this group at >>> http://groups.google.com/group/nodejs?hl=en?hl=en >> >> >> -- >> Job Board: http://jobs.nodejs.org/ >> Posting guidelines: >> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >> You received this message because you are subscribed to the Google >> Groups "nodejs" group. >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected] >> For more options, visit this group at >> http://groups.google.com/group/nodejs?hl=en?hl=en > > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
