Just out of curiosity, will this be the last nail in the coffin of 'binary' encoding? At least as the default, I mean.
On Tue, Oct 9, 2012 at 9:11 AM, Isaac Schlueter <[email protected]> wrote: > Seems pretty unanimous here. So, unless some new objection comes up > that is very compelling, let's assume that 0.10 will use Buffers by > default in crypto instead of binary strings. > > Also, a streaming interface to the crypto classes is already underway. > > > On Tue, Oct 9, 2012 at 9:06 AM, Jimb Esser <[email protected]> wrote: > > a) Go for it. Looks like it would have no effect on almost all of our > > crypto code. > > > > > > On Monday, October 8, 2012 4:24:36 PM UTC-7, Isaac Schlueter wrote: > >> > >> Currently, the crypto module defaults to using 'binary' encoded > >> strings everywhere as the default input and output encoding. > >> > >> This is problematic for a few reasons: > >> > >> 1. It's slower than necessary. > >> 2. It doesn't match the rest of Node. > >> > >> The reason for this is that crypto predates Buffers, and no one ever > >> bothered to go through and change it. (The same reason it's got some > >> odd hodgepodge of update/digest methods vs the Stream interface you > >> see everywhere else in node.) > >> > >> The reason it persists in 0.8 (and perhaps in 0.10) is that we > >> (perhaps overly optimistically) labelled that API "stable", and don't > >> want to break anyone's programs. It's going to change eventually to > >> match the rest of node. The only question is whether the change will > >> come in 0.10 or 0.12. A stream interface to all the crypto classes is > >> coming in 0.10; using 'binary' strings by default is thus even more > >> obviously a departure from the rest of node. > >> > >> Note that, if you only use crypto for hashes, and set the 'hex' > >> encoding, then it won't affect you. If you only ever pass the output > >> of one crypto function to the input of another (sign/verify, for > >> example) then it also won't affect you; you'll just pass buffers > >> around instead of binary strings. > >> > >> Please select one, and reply with your choice and perhaps any other > >> feedback you have on this issue. Thanks. > >> > >> a) Go for it. This won't affect me, and if by chance it does, I don't > >> mind putting 'binary' args here and there. > >> b) Please wait. Mark the API as unstable in 0.10, but don't change it > >> until 0.12. > >> c) I have no opinion, because I don't use the crypto API directly. > >> > >> > >> (Disclaimer: Node is not a democracy. The "winning" vote might still > >> be out-voted by reasonable considerations of the core dev team. This > >> is informative only ;) > > > > -- > > Job Board: http://jobs.nodejs.org/ > > Posting guidelines: > > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > > You received this message because you are subscribed to the Google > > Groups "nodejs" group. > > To post to this group, send email to [email protected] > > To unsubscribe from this group, send email to > > [email protected] > > For more options, visit this group at > > http://groups.google.com/group/nodejs?hl=en?hl=en > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en > -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
